Editorial: Properly format enum strings #418
Merged
+71
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @inexorabletash? |
inexorabletash
requested changes
Jun 20, 2023
a-sully
force-pushed
the
update-string-formatting
branch
from
50ef781
to
c7f70be
Compare
Before: `{{PermissionState/"granted"}}`
After: `"{{PermissionState/granted}}"`
See whatwg/fs#133
a-sully
force-pushed
the
update-string-formatting
branch
from
c7f70be
to
55810a9
Compare
github-actions bot
added a commit
that referenced
this pull request
Jun 20, 2023
Before: `{{PermissionState/"granted"}}`
After: `"{{PermissionState/granted}}"`
See whatwg/fs#133. Also called out here: #417 (comment)
SHA: 44df0c4
Reason: push, by @a-sully
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
{{PermissionState/"granted"}}After:
"{{PermissionState/granted}}"See whatwg/fs#133. Also called out here: #417 (comment)
Preview | Diff